Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where have the bootstrap .less files gone? #35

Open
robrecord opened this issue Nov 6, 2014 · 7 comments
Open

Where have the bootstrap .less files gone? #35

robrecord opened this issue Nov 6, 2014 · 7 comments

Comments

@robrecord
Copy link

I saw that with version 1.2, the less files have been removed for bootstrap. Can we have them back please?
Thanks!

@Frederic-C
Copy link

Same problem here, I was used to use _tk with Less files to quicly customize the theme. with pure CSS his is hell as any other basic theme. :/

At least you can download bootstrap source files and manually add LESS files (be sure to use the correct version)

@robrecord
Copy link
Author

Thank you Fred, yes I eventually did the same thing.

Should I/we submit a pull request?

@svenl77
Copy link
Contributor

svenl77 commented Jan 20, 2015

Hi @robrecord @Frederic-C

You are absolutely right. The less files should be included. You are welcome to create a pull request!

Latest Bootstrap pull: #38

Is this the latest version of bootstrap?

@svenl77
Copy link
Contributor

svenl77 commented Jan 20, 2015

Currently v3.3.2

Would be nice to update the theme to the latest version. If you are willing to help, you are more the welcome!

@Frederic-C
Copy link

Nope, bootstrap just get updated yesterday.
Be careful, when I used the LESS files and compiled I noticed some differences between bootstrap.css generated and the version in _tk. Mainly about webkit prefixes for some CSS rules (webkit rules are present in _tk version and not in bootstrap version) I don't know why these are different rules.

@svenl77
Copy link
Contributor

svenl77 commented Jan 20, 2015

true... all changes in the css should be located here: https://github.com/Themekraft/_tk/blob/master/includes/css/bootstrap-wp.css We could create a bootstrap-wp.less.

We also need to make sure that class names and so on didn't change or adjust it in the theme files.

If someone like to take the job and create a pull we can do an intensive review.

@robrecord
Copy link
Author

I would like to but don't have time this week; will try to revisit - if someone hasn't done it by then, I'll give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants