-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conflicting with Rive #2868
Comments
I've opened a PR that will fix the collision, can you try installing and testing from the PR and let us know if the issue is resolved, you may need to pod install again. |
Quick UPDATE: The App gets slow when i made these changes... It is like in 30 fps. |
This error is not related to react-native-video at all. If you can install and use the package then I would say the conflict with rive has been fixed. Renaming some files/interfaces isn't going to change the performance of your app. My project already had To help you debug, you can try changing BOOL interactionEnabled = !UIApplication.sharedApplication.isIgnoringInteractionEvents; to BOOL interactionEnabled = !RCTSharedApplication().isIgnoringInteractionEvents; And leave the I have stable 60fps for both UI and JS threads so I would assume the performance problems are coming from somewhere else in your app. I've created a PR in react-native with the above change though as I believe usage of |
as like i mentioned here in my post on rive github
these 2 libs are conflicting each other on XCode build time.
rive-app/rive-react-native#145
The text was updated successfully, but these errors were encountered: