Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicting with Rive #2868

Closed
Bayramito opened this issue Sep 25, 2022 · 4 comments · Fixed by #2870
Closed

conflicting with Rive #2868

Bayramito opened this issue Sep 25, 2022 · 4 comments · Fixed by #2870

Comments

@Bayramito
Copy link

as like i mentioned here in my post on rive github

these 2 libs are conflicting each other on XCode build time.

rive-app/rive-react-native#145

@evoactivity
Copy link
Contributor

I've opened a PR that will fix the collision, can you try installing and testing from the PR and let us know if the issue is resolved, you may need to pod install again.

@Bayramito
Copy link
Author

Bayramito commented Sep 26, 2022

I got this error once i renamed the folder and files in it...

i did pod install
Ekran Resmi 2022-09-26 10 30 48

EDIT: I managed to make it work by setting under Pods project > React-Core > Requires Only App-Extension-Safe-API to NO

But i dont know if this affect something other

@Bayramito
Copy link
Author

Quick UPDATE: The App gets slow when i made these changes... It is like in 30 fps.

@evoactivity
Copy link
Contributor

evoactivity commented Sep 26, 2022

This error is not related to react-native-video at all. If you can install and use the package then I would say the conflict with rive has been fixed. Renaming some files/interfaces isn't going to change the performance of your app.

My project already had Requires Only App-Extension-Safe-API set to no by default, so I'm not sure why yours was set to yes to begin with.

To help you debug, you can try changing

BOOL interactionEnabled = !UIApplication.sharedApplication.isIgnoringInteractionEvents;

to

BOOL interactionEnabled = !RCTSharedApplication().isIgnoringInteractionEvents;

And leave the Requires Only App-Extension-Safe-API set to yes, but I don't think the performance problems are from those changes.

I have stable 60fps for both UI and JS threads so I would assume the performance problems are coming from somewhere else in your app.

I've created a PR in react-native with the above change though as I believe usage of UIApplication.sharedApplication is an error.
facebook/react-native#34787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants