Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate entities after setting fields in registries #70

Closed
johanstokking opened this issue Jan 29, 2019 · 1 comment
Closed

Validate entities after setting fields in registries #70

johanstokking opened this issue Jan 29, 2019 · 1 comment
Assignees
@KrishnaIyer
Labels
c/application server This is related to the Application Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server

Comments

@johanstokking
Copy link
Member

Summary:

Validate entities after setting fields in registries, before storing it.

Why do we need this?

We need to verify that an entity doesn't get in an invalid state after setting individual fields, i.e. depending fields or conflicting things.

What is already there? What do you see now?

No validation in the registries.

What is missing? What do you want to see?

Validation in each registry.

How do you propose to implement this?

After SetFields(), call Validate() and return the error if any.

Original issue: https://github.com/TheThingsIndustries/lorawan-stack/issues/1348 by @johanstokking
@johanstokking johanstokking added c/application server This is related to the Application Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server l/open source labels Jan 29, 2019
@johanstokking johanstokking added this to the Backlog milestone Feb 6, 2019
@johanstokking johanstokking modified the milestones: Backlog, Next Up Mar 4, 2019
@johanstokking johanstokking mentioned this issue Mar 6, 2019
Merged
@htdvisser
Copy link
Contributor

@rvolosatovs says we already do this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrishnaIyer KrishnaIyer

Labels
c/application server This is related to the Application Server c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@htdvisser @KrishnaIyer @johanstokking