Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch camera button during device onboarding via mobile doesn't work #6529

Closed
2 of 4 tasks
KrishnaIyer opened this issue Sep 8, 2023 · 2 comments · Fixed by #6691
Closed
2 of 4 tasks

Switch camera button during device onboarding via mobile doesn't work #6529

KrishnaIyer opened this issue Sep 8, 2023 · 2 comments · Fixed by #6691
Assignees
Labels
bug Something isn't working c/console This is related to the Console
Milestone

Comments

@KrishnaIyer
Copy link
Member

Summary

Switch camera button during device onboarding via mobile doesn't work.
Ref: #6500

Steps to Reproduce

See https://github.com/TheThingsIndustries/lorawan-stack-support/issues/991#issuecomment-1710017134.
I have also tested this with an iPhone 12 Pro with Safari and Firefox.

Current Result

The switch camera button doesn't do anything visible on clicks.

Expected Result

The button should cycle through the cameras.
Since this is used by users to onboard devices, we need the users to be able to use the rear camera of their mobile phones.
The good thing is that I have consistently seen that it always shows the primary (rear) camera.
If we can somehow guarantee that this works, we don't even need to cycle I think.

Relevant Logs

See https://github.com/TheThingsIndustries/lorawan-stack-support/issues/991#issuecomment-1710017134

URL

No response

Deployment

The Things Stack Open Source (self-hosted)

The Things Stack Version

3.27.2

Client Name and Version

iPhone Pro with Firefox and Safari.

Other Information

No response

Proposed Fix

No response

Contributing

  • I can help by doing more research.
  • I can help by implementing a fix after the proposal above is approved.
  • I can help by testing the fix before it's released.

Code of Conduct

@KrishnaIyer KrishnaIyer added bug Something isn't working c/console This is related to the Console labels Sep 8, 2023
@KrishnaIyer KrishnaIyer added this to the v3.28.0 milestone Sep 8, 2023
@github-actions github-actions bot added the needs/triage We still need to triage this label Sep 8, 2023
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Sep 13, 2023
@ryaplots ryaplots added the in progress We're working on it label Oct 3, 2023
@ryaplots ryaplots mentioned this issue Oct 3, 2023
6 tasks
@ryaplots
Copy link
Contributor

Merged a fix which works for android. Although still broken on iPhone.

@ryaplots ryaplots removed the in progress We're working on it label Oct 23, 2023
@ryaplots ryaplots modified the milestones: v3.28.0, v3.28.1 Oct 23, 2023
@KrishnaIyer
Copy link
Member Author

@mjamescompton: Can you please pick this up since you have expertise in setting up dev environments for iOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants