Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Echo #2627

Closed
htdvisser opened this issue May 29, 2020 · 4 comments · Fixed by #4921
Closed

Remove dependency on Echo #2627

htdvisser opened this issue May 29, 2020 · 4 comments · Fixed by #4921
Assignees
Labels
c/shared This is shared between components technical debt Not necessarily broken, but could be done better/cleaner umbrella This issue needs actionable issues referenced
Milestone

Comments

@htdvisser
Copy link
Contributor

Summary

This issue tracks the removal of our dependency on Echo. We've already done some work, but we didn't have an issue to track it.

Why do we need this?

#2382 (comment)

What is already there? What do you see now?

A lot of work already done in #2382 and #2561

More upcoming removals in #2564

Some other pull requests removing other parts

What is missing? What do you want to see?

Complete removal

@htdvisser htdvisser added c/shared This is shared between components technical debt Not necessarily broken, but could be done better/cleaner umbrella This issue needs actionable issues referenced labels May 29, 2020
@htdvisser htdvisser added this to the Backlog milestone May 29, 2020
@KrishnaIyer KrishnaIyer removed this from the Backlog milestone Jun 8, 2021
@htdvisser htdvisser added this to the 2022 Conference milestone Oct 26, 2021
@htdvisser
Copy link
Contributor Author

Let's add this to the quarterly milestone. We haven't been able to upgrade Echo since v4.1.2 (released Apr 29, 2019) which is a really long time. At the same time, we don't actually need Echo, because we also use Gorilla mux router, so let's just remove what's left of Echo.

@johanstokking
Copy link
Member

johanstokking commented Oct 27, 2021

So we have:

  • pkg/account, pkg/oauth, pkg/web/oauthclient: @kschiffer
  • pkg/basicstation/cups: @KrishnaIyer
  • pkg/console and pkg/webui: @pgalic96 (touched these files last week and usage is very minimal)
  • pkg/gatewayserver/io/ws: @KrishnaIyer
  • pkg/web/middleware: @pgalic96 (needs non-echo variants)

General cleanup, may depend on the above (?)

  • pkg/errors/web: @htdvisser
  • pkg/ratelimit: @htdvisser (this is probably just deleting the middleware that has become obsolete)
  • pkg/util/test/assertions: @htdvisser (independent; the test assertions aren't being used)
  • pkg/web: @htdvisser and/or @johanstokking (definitely depends on removing usage above)

@htdvisser
Copy link
Contributor Author

pkg/web/middleware: @pgalic96 (needs non-echo variants)

Those should all already exist in pkg/webmiddleware.

@adriansmares
Copy link
Contributor

* `pkg/basicstation/cups`: @KrishnaIyer
* `pkg/gatewayserver/io/ws`: @KrishnaIyer

I'll steal this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/shared This is shared between components technical debt Not necessarily broken, but could be done better/cleaner umbrella This issue needs actionable issues referenced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants