Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove goreleaser fork #232

Closed
rvolosatovs opened this issue Mar 5, 2019 · 1 comment
Closed

Remove goreleaser fork #232

rvolosatovs opened this issue Mar 5, 2019 · 1 comment
Assignees
@rvolosatovs
Labels
technical debt Not necessarily broken, but could be done better/cleaner

Comments

@rvolosatovs
Copy link
Contributor

Summary:

#229 introduced a fork of goreleaser with goreleaser/goreleaser#978 merged, which should be removed, once the aforementioned PR is merged.

Why do we need this?

Because we want to limit the maintenance we need to do

What is already there? What do you see now?

Fork of goreleaser

What is missing? What do you want to see?

No fork of goreleaser

How do you propose to implement this?

Remove the fork
@rvolosatovs rvolosatovs added the technical debt Not necessarily broken, but could be done better/cleaner label Mar 5, 2019
@rvolosatovs rvolosatovs added this to the Backlog milestone Mar 5, 2019
@rvolosatovs rvolosatovs self-assigned this Mar 5, 2019
@rvolosatovs
Copy link
Contributor Author

PR has been merged, so once it lands in a new release, we can switch back to upstream and remove the fork

@rvolosatovs rvolosatovs mentioned this issue Mar 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvolosatovs rvolosatovs

Labels
technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rvolosatovs