-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This feature is only available with frameworks ['arduino']. #18
Comments
Welcome back :) Now it works fairly much everywhere (even using it on LibreTiny BK72xx devices now) I'm tempted to tidy it up a little and submit it for inclusion in ESPHome. Would you be OK with that? Want to be listed as a CODEOWNER? |
Thanks, I worked on this a bit a long while ago, I wanted to write a proper syslog client library which would be portable across projects, but it got abandoned due to lack of time. I just re-read the code, and it seems fine, the IETF format looks correct. Cool that it works with As for submitting for inclusion in ESPHome, it has already been suggested as a feature request, but that was a while ago. If cleaned-up and up to standards, they might want it (I'll be OK with it, same with being a codeowner) IMO, here are a few things that need to be done before :
Anyway, thanks for the PR, I'll try to build a dev environment in the following days |
Yeah, I have been thinking of fixing the escape code stuff; some of them do still escape. It does work when WiFi reconnects, but perhaps only if the IP address doesn't change. I'll see if I can test that. I also had DNS support on my TODO list before submitting it. |
Thank you for this! I was finally able to capture logs. I used the following config:
Some interesting things:
but that seems to only apply to the logs presented inside ESPhome not the syslog ones. Anyway much appreciate the work on this, I've been wanting log capture for a long time and this works! |
I suspect this version may break on rp2040 and esp8266 — we actually do need to use the Arduino UDP there. See discussion in esphome/esphome#4969 |
Thanks for the PR. Works fine here on |
Any chance we can get this to work with:
framework:
type: esp-idf
I need that for a different component (secplus_gdo) I believe.
The text was updated successfully, but these errors were encountered: