Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript is used as a dependency instead of a devDependency #2

Closed
opl- opened this issue Sep 13, 2020 · 1 comment
Closed

TypeScript is used as a dependency instead of a devDependency #2

opl- opened this issue Sep 13, 2020 · 1 comment

Comments

@opl-
Copy link

opl- commented Sep 13, 2020

TypeScript, when used only to build the package, should be specified as a devDependency. The package should be built before being published to npm, which makes TypeScript unnecessary when installing this package as a dependency for projects that are written in pure JavaScript.

This is supported by the TypeScript download page suggesting the use of --save-dev: https://www.typescriptlang.org/id/download

@TheRealSyler
Copy link
Owner

TheRealSyler commented Sep 13, 2020

fixed in 8a1c33d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants