json_difference_checker is bad function name

[Akuli]

Upwatch/upwatch.py

Line 103 in ef6f8d9

def json_difference_checker(

I was reading this code with Arrinao. I needed to read the whole function just to figure out what it was doing.

<Akuli> a job post is new if its url is not in old_job_urls, i.e. we have not seen that url before
<Akuli> and then it returns new job posts
<Akuli> so this part finds the job posts that you have not seen before
<Arrinao> ahh ok
<Arrinao> very cool
<Akuli> and it really should be named get_new_job_posts()
<Akuli> not json_difference_checker()