Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate HTML/CSS - Signup form project: discourage JS use #28056

Merged
merged 1 commit into from
May 26, 2024
Merged

Intermediate HTML/CSS - Signup form project: discourage JS use #28056

merged 1 commit into from
May 26, 2024

Conversation

fabulousgk
Copy link
Contributor

Because

Currently the project suggests using JS to validate the passwords as an optional excersise. However, we have been removing these sorts of things to discourage rabbit trails.

This PR

  • Rewords last step to discourage JS checking
  • Fixes some lining things

Issue

Closes #27271

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label May 25, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you as always!

@MaoShizhong MaoShizhong merged commit 64c2d11 into TheOdinProject:main May 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermediate HTML and CSS: Project: Sign-up Form
2 participants