Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint warning for "source" #1

Open
alejandrogomez314 opened this issue Jan 18, 2019 · 1 comment
Open

Lint warning for "source" #1

alejandrogomez314 opened this issue Jan 18, 2019 · 1 comment

Comments

@alejandrogomez314
Copy link

Thanks for making this project! Found out about it through your awesome ng-conf talk and its been very useful for me to learn more about marble testing.

My question is: when I run npm lint on the project I get the warning "source is deprecated: This is an internal implementation detail, do not use" for the following line in app.effects.spec.ts:

set stream(source: Observable<any>) {
    this.source = source;
}

Any idea on how I could implement something different to satisfy the linter? Thanks again.

@TheKeithStewart
Copy link
Owner

Hi, @agomez314! I'm glad that you found the talk and this project useful!

I'm not getting the linting warning that you are referring to when I run tslint. I am getting a number of other ones about training whitespaces and shadow name variables.

Have you updated tslint and/or codelyzer locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants