Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CuriosEquipEvent fired when curio is unequipped #305

Closed
dhyces opened this issue Apr 30, 2023 · 0 comments
Closed

CuriosEquipEvent fired when curio is unequipped #305

dhyces opened this issue Apr 30, 2023 · 0 comments
Assignees
@TheIllusiveC4
Labels
type: bug Something isn't working

Comments

@dhyces
Copy link

dhyces commented Apr 30, 2023

Versions:

  • Curios: 1.19.4-5.1.5.2
  • Forge/Fabric: Forge 45.0.49

Slot#mayPlace is called when the slot modification status is tested in Slot#allowModification, which results in the equip event being fired when Slot#tryRemove is called. Unfortunately, from the many times the event is fired when a slot is interacted with, this method is called from the last tryRemove method call. This results in unwanted behavior.
@dhyces dhyces added the type: bug Something isn't working label Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheIllusiveC4 TheIllusiveC4

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhyces @TheIllusiveC4