Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICurioItem#getEquipSound is never called #222

Closed
Aizistral opened this issue Feb 13, 2022 · 0 comments
Closed

ICurioItem#getEquipSound is never called #222

Aizistral opened this issue Feb 13, 2022 · 0 comments
Assignees
Labels
type: bug Something isn't working

Comments

@Aizistral
Copy link
Contributor

Versions:

  • Curios: 1.18.1-5.0.6.0
  • Forge/Fabric: 1.18.1-39.0.64

Observed Behavior:

The ICurioItem#getEquipSound method does not seem to be used at all, as default onEquipFromUse implementation redirects the call to playRightClickEquipSound, which in turns redirects to ICurio#playRightClickEquipSound on defaultInstance, which pulls the equip sound by invoking its own getEquipSound method, which always returns generic armor equip sound.

Expected Behavior:

Overriding ICurioItem#getEquipSound can actually be useful in some way.

Steps to Reproduce:

  1. Override ICurioItem#getEquipSound in your accessory class which implements ICurioItem;
  2. Return some custom sound of your choice;
  3. Load into the game and try to right-click-equip your accessory;
  4. Hear the default equip sound instead of your custom one;
  5. Contemplate the futility of your efforts.

Crash Log: none

@Aizistral Aizistral added the type: bug Something isn't working label Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants