[1.14.4] Equipped items vanishing in Creative

[Aizistral]

Versions:

• Curios: FORGE-1.14.4-1.0
• Forge: 28.1.1

Observed Behavior:

I've made a short video with demonstration of this issue. Hope it explains all well:

https://www.youtube.com/watch?v=WnoKJsv_l0g

Heart of Creation enables creative flight for player, and it's automatically disabled one time in LivingTick event when that item is removed from player's Curios slots. It the video, it well indicates the moment when player's curios vanish.

The issue was present across at least a couple of Curios versions already, but only recently I've been able to figure out the conditions at which it happens.

It is also quite inconsistent - sometimes it might happen, sometimes not. Sometimes changing the opened creative tab, unequipping, reequipping or equipping new trinkets might affect it, but there's seemingly no pattern or preferences.

Expected Behavior:

I would expect the trinkets to remain in their place rather than vanish into nothingness.

Steps to Reproduce:

1. Equip some trinkets in Curios inventory;
2. Open any creative tab;
3. Shift+Left-Click anywhere except interactive elements;
4. Behold!.. perhaps.

Here are at least some consistent details I've been able to figure out:

• The bug only happens when Shift-Clicking (either Left or Right click will suffice). Simple clicks or clicks while holding Ctrl instead of Shift never cause it;
• It only happens when a creative tab is opened. Clicking within player's creative inventory or Curios inventory doesn't seem to be able to reproduce this;
• It can be triggered by clicking in any place of the screen, even relatively far from displayable gui - as long as there are no interactive elements under cursor;
• When bug happens, it completely deletes everything equipped in Curios slots.
• Bug doesn't cause anything to be logged into console/log file - no errors or warnings, nothing.