Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DIV not ul#-ds-search-list for sharing number of matches #291

Open
Bojhan opened this issue Nov 29, 2024 · 0 comments
Open

Use DIV not ul#-ds-search-list for sharing number of matches #291

Bojhan opened this issue Nov 29, 2024 · 0 comments

Comments

@Bojhan
Copy link
Contributor

Bojhan commented Nov 29, 2024

We currently show a message for when there are too many matches.

We are now using <li role="region" class="type-ahead-alert" aria-live="assertive"> to announce "12 Matches, keep typing to refine your search".

This is abusing the li element which should only be used for lists. There should also be no need for "role".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant