Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security improvement - Integrity check #115

Open
stimmsoa opened this issue Nov 20, 2020 · 1 comment
Open

Security improvement - Integrity check #115

stimmsoa opened this issue Nov 20, 2020 · 1 comment

Comments

@stimmsoa
Copy link

Hi, in addition to my other security ticket related to this repos, could we also request you add an integrity check similar to:

<script src="/vendors_ps.js" integrity="sha384-OzzPYfictcWbXqp85AJACts0U9IkLCLgkfIYJhaGjMHnj9Q+NKtHwuQq55xR/SFf"></script> <script src="/ps.js" integrity="sha384-8ARGIdAYQInC8SUT5Y9HVND0YOf/rWzS9UO6wYFJHvdLK69nui01t50DRDQWqz3W"></script>

With the scripts being loaded in an iframe and then fetched by the browser, the integrity check would give another layer of security that the script has not been tampered with (even though it does come from the seamlessaccess domain)

Many thanks

@leifj
Copy link
Contributor

leifj commented Jan 10, 2021

This webpack plugin seems like it might do the trick: https://www.npmjs.com/package/webpack-subresource-integrity - however note the caveat about preloading. We have been investigating preloading as a mechanism of making the standard iframe button load faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants