Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Include Dockerfile at Analyzer Project level #606

Open
milesflo opened this issue Feb 8, 2020 · 3 comments
Open

[FR] Include Dockerfile at Analyzer Project level #606

milesflo opened this issue Feb 8, 2020 · 3 comments
Labels
category:feature-request Issue is related to a feature request

Comments

@milesflo
Copy link

milesflo commented Feb 8, 2020

Feature description
Include Dockerfile at project level to allow the creation of local Dockerized analyzers

Describe the solution you'd like
In each Analyzer directory, include a Dockerfile specifying the necessary build steps & entry point, with metadata labels.

Additional context
Doing this will be a great step in the direction this blog post was suggesting: moving from process based analyzer execution to docker based.

It will also address a concern myself and other have expressed by the project's use of docker helper scripts rather than the native Docker deployment system.

@milesflo milesflo added the category:feature-request Issue is related to a feature request label Feb 8, 2020
@milesflo milesflo mentioned this issue Feb 8, 2020
4 tasks
@nadouani
Copy link
Contributor

Hey @milesflo

I'm back to this issue + pull request. I think that the original requirement makes sense: "Allow the creation of local dockerized analyzers" but there are two issues here:

Let me explain it: Our CI pipeline (a private drone server) builds the docker images automatically (in addition to all the other packages), publish them etc... The docker images it produces contain all the metadata you have added in your script (we use the official docker metadata properties BTW).

We decided to not store the docker files in every analyzer folder.

That being said, we can update the script https://github.com/TheHive-Project/cortex-worker-builder to allow persisting dockerfiles for selected analyzers if you need to build them locally.

@milesflo
Copy link
Author

I disagree with your decision, and would appreciate if you would update that script.

@Xyrodileas
Copy link

Xyrodileas commented Jan 14, 2021

I support Milesflow's request. I've worked to redo the setup with Drone and was not able to. Really diminish the ability to contribute, test new features easily and trust the project for the long run as I have to trust binary hosted on a 3nd party website.
This is a major concern when wanting to migrate to TheHive/Cortex, contribute and ditch the previous ticket management system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:feature-request Issue is related to a feature request
Projects
None yet
Development

No branches or pull requests

3 participants