Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Bootstrap's transitions #993

Open
chsreedhar opened this issue Aug 18, 2018 · 4 comments
Open

Enabling Bootstrap's transitions #993

chsreedhar opened this issue Aug 18, 2018 · 4 comments

Comments

@chsreedhar
Copy link

Add Bootstrap: transition.js as default to all views for simple transition effects.
Transitions transition.js

@stephanrauh
Copy link
Collaborator

I didn't implement this yet, but I think it's a good idea.

I guess simply adding the library isn't enough. Can you give me a hint which components benefit from the fade CSS class? Are there other benefits of adding transition.js?

@chsreedhar
Copy link
Author

A few examples of the transition plugin:

Sliding or fading in modals
Fading out tabs
Fading out alerts
Sliding carousel panes

@TheTimeWalker
Copy link
Contributor

TheTimeWalker commented Aug 25, 2018

Actually from initial testing, simply adding the library seems to work out pretty well! I've used this file from v3.3.4 to test: https://raw.githubusercontent.com/twbs/bootstrap/master/js/transition.js

You then have to do is adding a class fade to stuff like modals, tab panes, etc. On some stuff like tab views, your first active pane needs to have a class in. With all that it works pretty much out of the box.

@stephanrauh
Copy link
Collaborator

stephanrauh commented Aug 26, 2018

Good point. Adding the transition.js dependency in your application is no big deal. Maybe we'll add them to the core library nonetheless because the default distribution of Bootstrap also includes transition.js.

@geopossachs geopossachs added this to the v2.0.0 milestone May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants