Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<p:dateTimePicker> locale problem #556

Closed
dajevtic opened this issue Nov 19, 2016 · 6 comments
Closed

<p:dateTimePicker> locale problem #556

dajevtic opened this issue Nov 19, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@dajevtic
Copy link

dajevtic commented Nov 19, 2016

Setting a locale other than the default causes a JavaScript error.
After investigating the problem i noticed that class DateTimePickerRenderer renders the locale attribute twice, which causes the problem.
Removing one rendering of the locale attribute (line (BsfUtils.isStringValued(dtp.getLocale()) ? "locale: [" + dtp.getLocale() + "], " : "") +) solved the issue for me...

Running on 1.0.0

@zhedar
Copy link
Collaborator

zhedar commented Nov 19, 2016

You're right. We're rendering the locale twice. The fix should be quite easy, but I will have another look at that, because I don't want the displayFormat messed up by a quick fix in any case.

@zhedar zhedar added the bug label Nov 19, 2016
@zhedar zhedar added this to the v1.0.1 milestone Nov 19, 2016
@zhedar zhedar self-assigned this Nov 19, 2016
@zhedar zhedar closed this as completed in 452697d Nov 19, 2016
@zhedar
Copy link
Collaborator

zhedar commented Nov 19, 2016

Thanks for the hint, I applied some minor refactorings by the way in a prior commit.

@stephanrauh
Copy link
Collaborator

@zhedar So it's solved in the current source code version?

@zhedar
Copy link
Collaborator

zhedar commented Nov 19, 2016

@stephanrauh Yep, I fixed it by checking and applying @dajevtic's suggestion in 452697d.

@stephanrauh
Copy link
Collaborator

@dajevtic I've just uploaded the latest version of BootsFaces to Maven Central. See #369 on how to get it. Please run a test and report us back.

Thanks in advance,
Stephan

@dajevtic
Copy link
Author

I can confirm that the new version solves this issue.
Thank you, guys! Keep up the great work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants