Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong style in navbar 0.8.5. #374

Closed
lyahim opened this issue May 11, 2016 · 10 comments
Closed

wrong style in navbar 0.8.5. #374

lyahim opened this issue May 11, 2016 · 10 comments
Assignees
Milestone

Comments

@lyahim
Copy link
Contributor

lyahim commented May 11, 2016

Hello All,

When I try to update to 0.8.5. the navbars rendered incorrectly. It looks like the styles are missing. My last used version is 0.8.1.

Thank you,
Mihaly

@asterd
Copy link
Collaborator

asterd commented May 11, 2016

@lyahim yes, you were right. We have already found this bug and also solved it in 0.8.6 branch (f1b5ebe). We hope to release a fix version asap!

@stephanrauh
Copy link
Collaborator

@asterd You say this issue has been solved in 0.8.6? If so, feel free to close the issue.

@lyahim
Copy link
Contributor Author

lyahim commented May 25, 2016

Hello All,

Please reopen the ticket, because not fixed yet.

Thank you,
Mihaly

@asterd
Copy link
Collaborator

asterd commented May 25, 2016

Hi @lyahim, can you send a screenshot of the style problem?

@lyahim
Copy link
Contributor Author

lyahim commented May 25, 2016

Hello asterd,

I attached. I hope successfully

Mihaly
navbar_good
navbar_wrong

@lyahim
Copy link
Contributor Author

lyahim commented May 25, 2016

I checked the navbar.css and looks like same the old and the new one. But in rendered code I see the li changed some place to span.

@lyahim
Copy link
Contributor Author

lyahim commented Jun 6, 2016

Hello All,

Is there any news?

Thank you,
Mihaly

@TheCoder4eu TheCoder4eu self-assigned this Jun 6, 2016
@TheCoder4eu
Copy link
Owner

@lyahim you did try this with 0.8.6 too, did you?

@stephanrauh
Copy link
Collaborator

stephanrauh commented Jun 6, 2016

I suppose your problems are caused by #310. A solitary <b:navLink /> is now rendered as a <span> instead of a <div>. I wonder why your menu items are considered solitary navLinks by BootsFaces? What does your JSF code look like? <b:navLink /> should be in one of the following containers:

  • DropButton
  • NavBar
  • TabLinks
  • PillLinks
  • NavBarLinks
  • DropMenu
  • FlyOutMenu

Otherwise, they are rendered as <span>.

@TheCoder4eu
Copy link
Owner

If Mihaly still has problems we should open a new issue on 0.9.0 and keep closed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants