Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make whole panel title clickable to toggle collapsed state #372

Closed
jpiersanti opened this issue May 8, 2016 · 2 comments
Closed

Make whole panel title clickable to toggle collapsed state #372

jpiersanti opened this issue May 8, 2016 · 2 comments
Milestone

Comments

@jpiersanti
Copy link

Hello guys,

Thanks a lot for the 0.8.5 version, it provides much more possibilities!

I have one quick question, is not an issue. While using the accordion component I have noticed that only the text in the title is clickable (as a link) in order to expand/collapse the panels.

Is there a way to make the entire title area (not only the text, but the title bar itself) clickable so the user can click anywhere on the title area?

Regards,

@zhedar
Copy link
Collaborator

zhedar commented May 8, 2016

This is something I experienced as well, it not only holds true for the accordion, it's an issue with all collapsible panels. The title text is an <a> which triggers the collapse.
We should find a way to make the whole title bar trigger the collapse, because that's what a user would normally expects and is much more mobile-friendly.

@zhedar
Copy link
Collaborator

zhedar commented May 8, 2016

I should have looked into this a bit further, it was too simple to solve. I'm checking, if I have overseen any corner cases before checking in a fix.
Edit: Done, refactored a duplicated code block just by the way.

@zhedar zhedar closed this as completed in 27f4ccd May 8, 2016
@zhedar zhedar changed the title accordion: make child panel's title bar clickable? Make whole panel title clickable to toggle collapsed state May 8, 2016
@zhedar zhedar added this to the v0.9.0 milestone May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants