Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: input mask for input fields #267

Closed
stephanrauh opened this issue Jan 22, 2016 · 14 comments
Closed

New feature: input mask for input fields #267

stephanrauh opened this issue Jan 22, 2016 · 14 comments

Comments

@stephanrauh
Copy link
Collaborator

This could be realized by a jQuery plugin, such as https://github.com/RobinHerbots/jquery.inputmask.

@stephanrauh stephanrauh added this to the v0.9.0 milestone Jan 22, 2016
@stephanrauh stephanrauh modified the milestones: v0.9.1, v0.9.0 Jun 30, 2016
@stephanrauh stephanrauh modified the milestones: v1.0.0, v0.9.1 Jul 10, 2016
@ahofmeister
Copy link
Contributor

Hi Stephan,

am I overseeing this feature in 0.9.1? I can not find it. :( I am really using 0.9.1. No snapshot, nothing.

@stephanrauh
Copy link
Collaborator Author

No, it's simply not there yet. But you're free to contribute it :). The idea being that the input mask should be added to b:inputText and b:inputTextArea (as opposed to creating a new component). I believe our inputText is flexible enough to support input masks.

@ahofmeister
Copy link
Contributor

Oh dear. I looked really forward to see that! Yeah, can you give me some time? :) I am really running out of it. I got confused by stephanrauh modified the milestone: v1.0.0, v0.9.1 on 10 Jul,.

@stephanrauh
Copy link
Collaborator Author

There's no hurry. Originally, we wanted to release BootsFaces 1.0 before the JavaOne conference, but we've decided to delay it.

@stephanrauh
Copy link
Collaborator Author

@TheCoder4eu TheCoder4eu self-assigned this Feb 27, 2017
@TheCoder4eu TheCoder4eu modified the milestones: v1.5.0, v1.1.0 Mar 19, 2017
@jepsar
Copy link
Contributor

jepsar commented May 21, 2017

Though Robin Herbots plugin looks good, it is quite large and probably only a little part of it is needed. How about https://github.com/estelle/input-masking ? Looks good enough to me.

@stephanrauh
Copy link
Collaborator Author

Good hint. At first glance, I don't see any reason not to use Estelle's library.

@jepsar
Copy link
Contributor

jepsar commented May 22, 2017

I've been playing with Estelle's library for a while, and it does not feel solid. I've seen some glitches in updating the placeholder.

The idea being that the input mask should be added to b:inputText and b:inputTextArea (as opposed to creating a new component)

Doesn't this mean that input mask resources need to be loaded, even when they are not used?
Looks like you are able to add resources when an attribute is used :-)

Let me have a look what the minimal set of js files from Robin's library will weigh.

@jepsar
Copy link
Contributor

jepsar commented May 22, 2017

The JS file was about 75kB.

See PR #791

I did not add it to the b:inputTextArea. Would that be useful? I don't think so.

@stephanrauh stephanrauh modified the milestones: v1.1.2, v1.5.0 May 22, 2017
@stephanrauh
Copy link
Collaborator Author

@jepsar The feature works on my local machine, but not on our showcase (http://www3.bootsfaces.net/Showcase/forms/inputText.jsf). The only difference I've spotted so far is that the JavaScript code is not included with the minified code generated by the CombinedResourceHandler of OmniFaces. Can you have a look at the problem?

Otherwise, thanks for the good work! I think we're almost there!

@jepsar
Copy link
Contributor

jepsar commented May 23, 2017

@stephanrauh I'll have a look tonight. The embedded JavaScript is also not rendered. I simply build using the pom.xml where I've updated the BootsFaces dependency to 1.1.2-SNAPSHOT. Probably something Gradle related in the showcase.

@jepsar
Copy link
Contributor

jepsar commented May 23, 2017

@stephanrauh As expected, I missed a dependency in gradle.build. I now used Gradle to build and the resulting war contained the correct jar (including the mask plugin).

See PR TheCoder4eu/BootsFacesWeb#47

@TheCoder4eu
Copy link
Owner

@stephanrauh the PR is merged.

@TheCoder4eu
Copy link
Owner

The example is working in the devel showcase.
Thanks @jepsar and @stephanrauh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants