-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Create a pull request for the Clang Tidy #2492
Comments
this seems like a good idea |
This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Detailed description
Currently, all of the Clang Tidy changes are being pushed in forks and appearing in other pull requests. However, these changes are not being pushed to the original repository due to the
main
branch being protected. This can be fixed by creating a pull request (running the action only on this repository) and then the maintainers merging the PR to reflect the changes.Context
This will make it better for both PR creators and reviewers.
Possible implementation
Create a pull request instead of committing directly.
Additional information
We could also make the check fail if the user has missed anything and let the user fix the errors themselves.
It depends on what you like most. Having a PR created makes it easier and faster. Having the user fix the errors themselves helps them learn.
Let me know your thoughts.
The text was updated successfully, but these errors were encountered: