Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC not rendering correctly #27

Closed
vegarringdal opened this issue May 10, 2021 · 2 comments
Closed

IFC not rendering correctly #27

vegarringdal opened this issue May 10, 2021 · 2 comments

Comments

@vegarringdal
Copy link
Contributor

I can send sample files on discord in a PM

With web-ifc I get this:
1
image

2 (overlook the red color)
image

In blender:
1
image
2
image

@tomvandig
Copy link
Contributor

tomvandig commented May 25, 2021

Just implemented the missing component, result can be tested here: https://tomvandig.github.io/web-ifc/examples/viewer/index.html

To make the model visible, I also had to solve a coordination issue, so models are now default coordinated on the first element found. This will have to change in the future.

Your second model is actually rendering "correctly", however the default number of segments in a circle is currently set to 5, which I admit is a bit of a loose definition of circle. Updated it to 12. Will make this option configurable in the future.

@vegarringdal
Copy link
Contributor Author

vegarringdal commented May 25, 2021

@tomvandig Awesome work. 👍 🥇

To make the model visible, I also had to solve a coordination issue, so models are now default coordinated on the first element found. This will have to change in the future.

About the coordinates, dont think about it, I did a update to viewer repo that will focus model but its not set a default behavior behavior atm.
https://github.com/agviegas/web-ifc-viewer/blob/master/viewer/src/core/viewer.ts#L133-L155

Update: Really cool you added focus part to test part, easier for me to do a quick test to see what part to extract next 👍

Closing this issue.
If I find any new bugs Ill create a new issue and send you model files on discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants