Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing position of FragmentsGroup leads to inconsistent behaviour #39

Open
5 tasks done
fwestling-ark opened this issue Sep 5, 2024 · 0 comments
Open
5 tasks done
Labels
bug Something isn't working

Comments

@fwestling-ark
Copy link

Describe the bug 📝

I am moving the position of my FragmentsGroups within the scene coordinate system based on third-party offsets. Some tools work as expected (Highlighter correctly highlights the element) but others do not (Outliner outlines the original position rather than the update).

It seems like what's happening is that there is underlying geometry of the fragments not being updated; I suspect I can loop through them to update them manually, but I feel this shouldn't be necessary

image

Reproduction ▶️

No response

Steps to reproduce 🔢

Set up an example following https://docs.thatopen.com/Tutorials/Components/Front/Highlighter.

Before calling world.scene.three.add(model);, update the position of the model:

...
const model = fragments.load(buffer);

// Add these two lines:
model.position.set(10, 0, 0);
model.lookAt(0, 0, 10);
 
world.scene.three.add(model);
...

System Info 💻

System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz
    Memory: 9.56 GB / 31.87 GB
  Binaries:
    Node: 20.16.0 - ~\AppData\Local\fnm_multishells\28108_1725495973564\node.EXE
    Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 10.8.1 - ~\AppData\Local\fnm_multishells\28108_1725495973564\npm.CMD
  Browsers:
    Edge: Chromium (127.0.2651.86)
    Internet Explorer: 11.0.22621.3527


 "dependencies": {
    "@thatopen/components": "^2.2.9",
    "@thatopen/components-front": "^2.2.2",
    "@thatopen/fragments": "^2.2.0",
    "@thatopen/ui": "^2.2.0",
...
}

Used Package Manager 📦

yarn

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@fwestling-ark fwestling-ark added the bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant