V1 rewrite #40
Merged
V1 rewrite #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing to the config I use with SoftHSM. Still won't suit most people, but neither did the original.
Apologies for massive commit, but rather difficult to split a wholesale change into small parts. Many aspects are yet to be done, including changing id/label behaviour, adding attributes, adding cert support, etc. Completely untested; tests expected to fail.
added 15 commits
April 26, 2019 07:31
Fixes #37.
Accidentally muddled two commits on different topics.
added 8 commits
April 29, 2019 15:33
We can no longer test this, as we update the source code
This commit also addresses an issue where errors during Configure resulting in the PKCS#11 library remaining initialized. Now all error paths kill the library.
nickrmc83
reviewed
May 1, 2019
nickrmc83
suggested changes
May 1, 2019
|
I've pushed a few more changes. Mostly about removing errors from our API. However, I decided to adjust the find keys stuff so it returns nil if the keys aren't found, not an error. |
|
The tag for this release is |
|
Thanks @cbroglie, I've just corrected that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-write of crypto11 to implement various backwards-incompatible design changes. This PR will be released as v1.0.0, beginning a new commitment to API stability.
Many of the topics in #36 are addressed, plus several outstanding issues:
The main thing discussed in #36 that wasn't implement was the
WithAttributesfunctions. I'm not sure they are needed, so I'm happy to wait for someone to request them. I'll create an issue to capture that as a potential enhancement. There is a branch,with-attributes, the contains the beginning of some work on this. #20 also hasn't been implemented, but it will be.