Adding vendoring via dep, and updated README.md #1
Conversation
README.md
Outdated
| git clone [email protected]:ThalesIgnite/crypto11.git github.com/ThalesIgnite/crypto11 | ||
| cd github.com/ThalesIgnite/crypto11 | ||
| go get github.com/ThalesIgnite/crypto11 | ||
| cd $GOPATH/sr/github.com/ThalesIgnite/crypto11 |
There was a problem hiding this comment.
Typo: sr should be src.
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| branch = "master" | ||
| name = "github.com/thalesignite/crypto11" |
There was a problem hiding this comment.
The last constraint here seems a strange - it is declaring a dependency on ourselves.
Is there a reason for that or was a result of dep init making a bad guess?
There was a problem hiding this comment.
Got it!
dep init doesn't want to write a Gopkg.toml that lists the repo itself. But it seems that it does a case-insensitive comparison. So if you clone github.com/ThalesIgnite/crypto11, it doesn't notice that the demo's import github.com/thalesignite/crypto11 is actually the same thing.
Per https://blog.golang.org/package-names Go package names are lower case, so I think the answer is we need to stop with the camelcase in ThalesIgnite. I'll adjust the README.md accordingly, and fix up the .toml files.
Lots of things get confused otherwise, among them 'dep init'.
This PR adds
depvendoring and an updated README.md to go with it