Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic due to misaligned atomic variables #35

Closed
techninja1008 opened this issue Mar 16, 2019 · 3 comments · Fixed by #40
Closed

Panic due to misaligned atomic variables #35

techninja1008 opened this issue Mar 16, 2019 · 3 comments · Fixed by #40
Milestone

Comments

@techninja1008
Copy link

techninja1008 commented Mar 16, 2019

In the dependency vitessio/vitess, a panic is caused on certain architectures due to misaligned variables. This will be fixed by vitessio/vitess#4729. When this is merged, the dependency will need to be re-vendored.

@dmjones
Copy link
Contributor

dmjones commented Mar 18, 2019

Thanks for the heads up 👍

@techninja1008
Copy link
Author

The upstream has been merged, so it would be good if we could vendor it? Should I submit a pull request, or leave it to @dmjones ?

@dmjones
Copy link
Contributor

dmjones commented Apr 15, 2019

@techninja1008 Sorry for the slow response, just back in the office. A PR would be very welcome, thanks!

@dmjones dmjones added this to the v1.0.0 milestone Apr 15, 2019
@dmjones dmjones mentioned this issue Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants