From d68adb9900c5ef136048b3484c29092fd46b94d2 Mon Sep 17 00:00:00 2001 From: Vizonex <114684698+Vizonex@users.noreply.github.com> Date: Fri, 24 Mar 2023 14:35:38 -0500 Subject: [PATCH 1/3] Fix Install for windows users I found a solution that by not passing "-Wno-deprecated" allowed me to install the library without any problems --- setup.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index 969af4e..76b78f6 100644 --- a/setup.py +++ b/setup.py @@ -2,7 +2,7 @@ from os import path from Cython.Build import cythonize - +import sys this_directory = path.abspath(path.dirname(__file__)) with open(path.join(this_directory, 'README.md'), encoding='utf-8') as f: @@ -21,7 +21,8 @@ extra_compile_args=[ "-std=c++17", # for std::string_view class that became standard in C++17 "-Wno-deprecated", - ], + # NOTE Windows doesn't know how to handle "-Wno-deprecated" + ] if sys.platform != "win32" else ["-std=c++17"], ) ] From 07a4df80c68ef30cec337f77790c3a595228321c Mon Sep 17 00:00:00 2001 From: Vizonex <114684698+Vizonex@users.noreply.github.com> Date: Fri, 24 Mar 2023 14:43:31 -0500 Subject: [PATCH 2/3] Refix Windows Pip install Just made another edit to my last one incase needed --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 76b78f6..7c056b8 100644 --- a/setup.py +++ b/setup.py @@ -22,7 +22,7 @@ "-std=c++17", # for std::string_view class that became standard in C++17 "-Wno-deprecated", # NOTE Windows doesn't know how to handle "-Wno-deprecated" - ] if sys.platform != "win32" else ["-std=c++17"], + ] if sys.platform != "win32" else ["/std=c++17"], ) ] From 17c993149950638d35b41aeb23fbe53ff7cd5776 Mon Sep 17 00:00:00 2001 From: Vizonex <114684698+Vizonex@users.noreply.github.com> Date: Fri, 24 Mar 2023 14:57:33 -0500 Subject: [PATCH 3/3] Came up with actual fix sorry for my typos :( --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 7c056b8..8ef5791 100644 --- a/setup.py +++ b/setup.py @@ -22,7 +22,7 @@ "-std=c++17", # for std::string_view class that became standard in C++17 "-Wno-deprecated", # NOTE Windows doesn't know how to handle "-Wno-deprecated" - ] if sys.platform != "win32" else ["/std=c++17"], + ] if sys.platform != "win32" else ["/std:c++17"], ) ]