Fix wrong comment on disabling MSVC exceptions #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/EHsc` does not actually disable exceptions on MSVC, it only makes the compiler assume that `extern "C"` functions never throw C++ exceptions. We had a discussion on Discord about actually disabling exceptions, and from research, that requires defining `_HAS_EXCEPTIONS=0`, but it's unsupported and undocumented so we deemed the benefits not worth it. Thus, we will stay with `/EHsc`. But the comment still has to be updated. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/EHscdoes not actually disable exceptions on MSVC, it only makes the compiler assume thatextern "C"functions never throw C++ exceptions.We had a discussion on Discord about actually disabling exceptions, and from research, that requires defining
_HAS_EXCEPTIONS=0, but it's unsupported and undocumented so we deemed the benefits not worth it. Thus, we will stay with/EHsc. But the comment still has to be updated.[skip ci]
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORSfile and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement