Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionReceipt missing fields #7

Closed
uhhhh2 opened this issue May 9, 2019 · 2 comments · Fixed by #8
Closed

TransactionReceipt missing fields #7

uhhhh2 opened this issue May 9, 2019 · 2 comments · Fixed by #8
Assignees
@nebojsa94
Labels
bug Something isn't working

Comments

@uhhhh2
Copy link

uhhhh2 commented May 9, 2019 •
edited
Loading

According to https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_gettransactionreceipt, a TransactionReceipt should contain:

  • transactionHash
  • transactionIndex
  • blockHash
  • blockNumber
  • from
  • to
  • cumulativeGasUsed
  • gasUsed
  • contractAddress
  • logs
  • logsBloom

However, the TransactionReceipt interface used in this project (https://github.com/Tenderly/tenderly-cli/blob/master/ethereum/types.go#L69) appears to be missing the fields in bold above.
@nebojsa94
Copy link
Member

Great catch! It seems we somehow missed those fields. 😔
We’ll be pushing out an update ASAP and I’ll ping your here when it’s live!

Thanks for the heads up!

@nebojsa94 nebojsa94 added the bug Something isn't working label May 9, 2019
@nebojsa94 nebojsa94 self-assigned this May 9, 2019
@nebojsa94 nebojsa94 mentioned this issue May 9, 2019
Merged
@BogdanHabic
Copy link
Member

Just wanted to ping here that v0.2.10, that contains this fix has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebojsa94 nebojsa94

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds missing fields in getTransactionReceipt rpc response. Tenderly/tenderly-cli
3 participants
@uhhhh2 @BogdanHabic @nebojsa94