Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs: 路径错误时解析URL报错 #22

Closed
liRemons opened this issue Aug 2, 2022 · 2 comments
Closed

bugs: 路径错误时解析URL报错 #22

liRemons opened this issue Aug 2, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@liRemons
Copy link

liRemons commented Aug 2, 2022

文件路径：wujie-core/utils.ts

函数体：fixElementCtrSrcOrHref
代码：new URL(value, this.baseURL || '')
当 value 不是合法的URL时，会报错，阻塞继续渲染
建议增加容错

示例：将子应用的url 设为 http://remons.cn/@website_pages/my
@yiludege
Copy link
Collaborator

yiludege commented Aug 2, 2022

确实代码容错这块做的不够，不过这个地方value为非法URL值和子应用的url应该没有关系吧

@yiludege yiludege added the enhancement New feature or request label Aug 2, 2022
@liRemons
Copy link
Author

liRemons commented Aug 2, 2022

是的，value和子应用URL没有关系，这里只是举个例子

@yiludege yiludege mentioned this issue Aug 8, 2022
Merged
2 tasks
@yiludege yiludege closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yiludege @liRemons