feat: jsExcludes 和 cssExcludes 支持正则 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看了一下代码写的很棒！可以对getExcludes和isExcludeUrl写点单元测试，由于子应用的加载涉及对iframe处理，jsdom没有办法对iframe进行有效的模拟导致子应用加载失败，所以我这边大多是集成测试为主 |
OK，我这边会把单元测试和 exclude 相关的集成测试都做一下 |
|
已经完成了，大佬可以再看一下 |
yiludege
approved these changes
Aug 4, 2022
|
|
||
| test('sourceType is "jsExcludes", should return jsExcludes', () => { | ||
| const jsExcludes = ['https://www.foo/a.js', /b\.js/]; | ||
| const plugins = [ |
There was a problem hiding this comment.
用例都很完整，这个地方plugins为一个数组，可以给一个复杂一点的场景plugins = [{jsExcludes: jsExcludes1}, {jsExcludes: jsExcludes2}, ....]来测试验证吗。
There was a problem hiding this comment.
好的，周末会多贡献一些代码，我看到单元测试还有很多可以补充的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
相关 isssue：#20
目标：支持更加灵活的 jsExcludes 和 cssExcludes
大佬先看以下改动的时候可以，如果可以，我再补充以下测试用例