Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol.toStringTag support is missing #606

Open
CetinSert opened this issue Feb 27, 2023 · 4 comments
Open

Symbol.toStringTag support is missing #606

CetinSert opened this issue Feb 27, 2023 · 4 comments
Labels
Details wanted Need more details

Comments

@CetinSert
Copy link

CetinSert commented Feb 27, 2023

vConsole Version: 3.15.0
ignores Symbol.toStringTag

const user = {
  firstName: 'John',
  lastName: 'Doe',
  [Symbol.toStringTag]: 'User',
}; user

vConsole ❌ | ✔️ Chrome DevTools
image

Please add support for this!

@CetinSert
Copy link
Author

Add support for

  • Set
  • Map
  • Request
  • Headers
  • Response

@Maizify
Copy link
Collaborator

Maizify commented Jun 1, 2023

You can see these properties after expanding

image

@Maizify Maizify added the Details wanted Need more details label Jun 1, 2023
@CetinSert
Copy link
Author

CetinSert commented Jun 2, 2023

@Maizify – It should do so before expanding to better match native consoles, otherwise vConsole is not doing a good job (of virtualizing).

Given,

const user = {
  firstName: 'John',
  lastName: 'Doe',
  [Symbol.toStringTag]: 'User',
}; user
  • vConsole output just reads Object {firstName: "John", lastName: "Doe"} without expanding the object!
  • native console output reads User {firstName: "John", ... even without expanding.
    native

Native consoles also output Set, Map, Request, Headers, and Response better than vConsole.

@CetinSert
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Details wanted Need more details
Projects
None yet
Development

No branches or pull requests

2 participants