Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?] [Table] table-header 并不存在 columnsProp，但是传了值 #63

Closed
1 of 4 tasks
backrunner opened this issue Dec 23, 2021 · 3 comments
Closed
1 of 4 tasks

[Bug?] [Table] table-header 并不存在 columnsProp，但是传了值 #63

backrunner opened this issue Dec 23, 2021 · 3 comments
Labels
to be published fixed, not be published

Comments

@backrunner
Copy link
Contributor

backrunner commented Dec 23, 2021 •
edited
Loading

Describe Framework

  • tdesign-vue
  • tdesign-vue-next
  • tdesign-react
  • tdesign-miniprogram

Describe Environment

Latest Chrome stable, mac os

复现地址：https://tdesign.tencent.com/vue/components/table?tab=demo

Describe the bug

偶然注意到一个问题，table 组件的 thead 标签里有找不到对应 prop 的绑定。
image

翻查代码发现 src/table/base-table/index.tsx 中有给 TableHeader 绑定相关值，
image

但是 table-header 里实际上并没有这个prop（路径： src/table/base-table/table-header.tsx）。

image

这里是编码失误，还是 columnsProp 在 table-header 中是有用途的？
@chaishi
Copy link
Collaborator

chaishi commented Dec 24, 2021

处理 PR：#80

@chaishi
Copy link
Collaborator

chaishi commented Dec 24, 2021

PR 已合并，待发布

@chaishi chaishi added the to be published fixed, not be published label Dec 24, 2021
@chaishi chaishi mentioned this issue Dec 24, 2021
Closed
@chaishi chaishi closed this as completed Dec 27, 2021
@chaishi chaishi reopened this Dec 27, 2021
@uyarn
Copy link
Collaborator

uyarn commented Jan 9, 2022

fixed in 0.33

@uyarn uyarn closed this as completed Jan 9, 2022
start940315 referenced this issue in start940315/tdesign-vue Mar 28, 2022
@chaishi
Merge pull request #63 from TDesignOteam/refactor_classname
76a4778 
refactor: update Dialog/Message/Notification/Badge/List/Divider classname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chaishi @backrunner @uyarn