Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image] 组件支持 globalConfig 配置字段 #2063

Closed
honkinglin opened this issue Jan 31, 2023 · 4 comments
Closed

[Image] 组件支持 globalConfig 配置字段 #2063

honkinglin opened this issue Jan 31, 2023 · 4 comments
Labels
💪🏻 enhancement New feature or request

Comments

@honkinglin
Copy link
Collaborator

这个功能解决了什么问题

缺少接收 errorText loadingText 全局配置字段

你建议的方案是什么

支持 errorText loadingText 字段全局配置

@github-actions
Copy link
Contributor

👋 @honkinglin,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@xiaosansiji xiaosansiji added the 🙏 help wanted Extra attention is needed label Jan 31, 2023
@github-actions
Copy link
Contributor

任何人都可以处理此问题。
请务必在您的 pull request 中引用此问题。
感谢你的贡献! ✨

@xiaosansiji
Copy link
Collaborator

xiaosansiji commented Jan 31, 2023

image

https://github.com/Tencent/tdesign-vue/pull/2062/files#diff-6dd4ce75a07d96bfd583450cbcce194a5e83460befd6314da06924684961c0e2R331

Image 和 ImageViewer 需要把现在 hard code 实现的内容 https://github.com/Tencent/tdesign-vue/blob/develop/src/image/image.tsx#L168
替换为支持全局配置的字符串变量方式,以满足多语言和其他用户全局配置诉求

@xiaosansiji
Copy link
Collaborator

xiaosansiji commented Jan 31, 2023

#2064

TDesign 桌面端 web 技术栈的三个框架,都需要实现

@uyarn uyarn added the to be published fixed, not be published label Feb 6, 2023
@uyarn uyarn closed this as completed Feb 9, 2023
@chaishi chaishi added 💪🏻 enhancement New feature or request and removed 🙏 help wanted Extra attention is needed to be published fixed, not be published labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪🏻 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants