Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): refactoring nav render function to fix error in production #4787

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Cat1007
Copy link
Collaborator

@Cat1007 Cat1007 commented Nov 28, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复

🔗 相关 Issue

#4690

💡 需求背景和解决方案

查看报错,会落到 vue 中的此处代码
企业微信截图_ccab1825-17db-4845-96b0-a4f35d825cee

因为 nav 渲染中使用到了 ref 特性,但是原实现中,nav 的内容渲染使用了一个 computed 进行实现,比较不合理,重构了相关的渲染函数

📝 更新日志

  • fix(Tabs): 修正渲染函数导致的生产版本错误

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn
Copy link
Collaborator

uyarn commented Nov 28, 2024

@PengYYYYY 这个先别合并

Copy link
Contributor

完成

@uyarn uyarn changed the title fix: 🐛 重构渲染函数,避免生产环境报错 fix(Tabs): refactoring nav render function to fix error in production Nov 29, 2024
@uyarn
Copy link
Collaborator

uyarn commented Nov 29, 2024

@PengYYYYY 这个先别合并

已验证

@PengYYYYY PengYYYYY merged commit e639a3c into Tencent:develop Nov 29, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants