Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] 在modeless下,同时设置draggable和 destroyOnClose 在关闭弹窗时会报错 #2521

Closed
homker opened this issue Mar 7, 2023 · 2 comments
Assignees
Labels
to be published to be published

Comments

@homker
Copy link

homker commented Mar 7, 2023

tdesign-vue-next 版本

1.1.1

重现链接

No response

重现步骤

dialog组件设置如下

<template>
<div>
  <t-button @click="visible = true">Open Modal</t-button>
  <t-dialog
    destroyOnClose
    mode="modeless"
    draggable v-model:visible="visible">
     <p>This is a dialog</p>
   </t-dialog>
 </div>
</template>

此时打开,关闭dialog,在控制台必现一个报错

image

期望结果

不报错

实际结果

No response

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

错误原因是
// dialog.tsx:283
image

动画结束之前,这个dom如果已经被销毁了,这个value的指向就不存在了。
这里其实可以判断,如果是关闭 销毁的模式,就不需要重置样式了

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

👋 @homker,感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善,我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

♥️ 有劳 @LeeJim @caoML @vnues @huoyuhao 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @homker

@PengYYYYY PengYYYYY added the to be published to be published label Mar 14, 2023
@PengYYYYY PengYYYYY mentioned this issue Mar 14, 2023
15 tasks
@github-actions github-actions bot mentioned this issue Mar 15, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be published to be published
Projects
None yet
Development

No branches or pull requests

3 participants