Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-next): fix vuejs ugrade issue #4004

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

gguoyu
Copy link
Collaborator

@gguoyu gguoyu commented Aug 26, 2024

  1. fix vuejs 3.4.32 patchProps API change issue
  2. compatible vuejs compiler-core API change issue
  3. upgrade vue-next demo package version
  4. upgrade vue-next-ssr demo package version & fix bug

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

1. fix vuejs 3.4.32 patchProps API change issue
2. compatible vuejs compiler-core API change issue
3. upgrade vue-next demo package version
@github-actions github-actions bot added driver: js size: m Denotes a PR that changes 100-499 lines labels Aug 26, 2024
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

hippy-service bot commented Aug 26, 2024

Hi, @gguoyu. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

1. compatible vue upgrade issue
2. fix vue-next-ssr demo issue
@zealotchen0 zealotchen0 merged commit 700cfdf into Tencent:main Sep 11, 2024
18 of 22 checks passed
Copy link

hippy-service bot commented Sep 11, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

zealotchen0 pushed a commit that referenced this pull request Nov 5, 2024
* fix(vue-next): fix vuejs ugrade issue

1. fix vuejs 3.4.32 patchProps API change issue
2. compatible vuejs compiler-core API change issue
3. upgrade vue-next demo package version

* fix(vue-next): fix vue-next-ssr-demo issue

1. compatible vue upgrade issue
2. fix vue-next-ssr demo issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants