Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): issues of ScrollEvent #3362

Merged
merged 4 commits into from
Jul 10, 2023
Merged

fix(android): issues of ScrollEvent #3362

merged 4 commits into from
Jul 10, 2023

Conversation

xxrlzzz
Copy link
Contributor

@xxrlzzz xxrlzzz commented Jul 7, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@xxrlzzz xxrlzzz requested a review from siguangli as a code owner July 7, 2023 07:35
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Jul 7, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 7, 2023

Hi, @xxrlzzz. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jul 7, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@siguangli siguangli requested a review from iPel July 7, 2023 07:37
@hippy-service
Copy link

hippy-service bot commented Jul 10, 2023

After a quick scan, I have approved workflow to run.

@siguangli siguangli added the action(squash-merge) Squash and merge action label Jul 10, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 10, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 10, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jul 10, 2023

⚠️ squash-merge action execution failed, because of pull request title does not meet the Convention Commit guideline.

Please check the following details:

⧗   input: Fix issues of ScrollEvent on android
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   header subject cannot be empty [function-rules/header-min-length]
✖   scope may not be empty [scope-empty]

✖   found 4 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@siguangli

@hippy-actions hippy-actions bot added the action(squash-merge): failed Squash and merge action execution failed label Jul 10, 2023
@xxrlzzz xxrlzzz changed the title Fix issues of ScrollEvent on android fix(android): issues of ScrollEvent Jul 10, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Jul 10, 2023
@hippy-actions hippy-actions bot removed the action(squash-merge): failed Squash and merge action execution failed label Jul 10, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 10, 2023 11:54
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 10, 2023
@hippy-actions hippy-actions bot merged commit b23d1ec into Tencent:main Jul 10, 2023
zealotchen0 pushed a commit that referenced this pull request Jul 25, 2023
@xxrlzzz @siguangli @zealotchen0
fix(android): issues of ScrollEvent (#3362)
733f303 
* fix(android): fix listview contentOffset on horizontal layout

take from 033b832

* fix(android): add controll flag for emit scroll event when overpull

---------

Co-authored-by: siguangli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

@iPel iPel iPel approved these changes

Assignees
No one assigned
Labels
renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xxrlzzz @iPel @siguangli