Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Connector should push message back to rabbitmq if function call fails #89

Closed
jebos opened this issue Mar 12, 2021 · 3 comments · Fixed by #91
Closed

[FR] Connector should push message back to rabbitmq if function call fails #89

jebos opened this issue Mar 12, 2021 · 3 comments · Fixed by #91
Assignees
Labels
design Design the solution enhancement New feature or request will_implement The enhancement will be implemented

Comments

@jebos
Copy link

jebos commented Mar 12, 2021

Is your feature request related to a problem? Please describe.
In case openfaas is busy (timeout), or there is an error (response !=2xx), it seems required that the connector pushes the message back to the queue in order to avoid data to be lost.

Describe the solution you'd like
As mentioned, I think it would be nice if the message is pushed back to the queue, it may seem also a good idea to throttle execution in general (or in this case) to avoid highload loops, in case openfaas is not available.

Describe alternatives you've considered

Additional context
100.000 messages in a queue that shall be pushed through one single, not scaleable function (due to system limits and cost contrains - but not time constrains)

@jebos jebos added design Design the solution enhancement New feature or request labels Mar 12, 2021
@Templum Templum added the will_implement The enhancement will be implemented label Mar 12, 2021
@Templum Templum self-assigned this Mar 12, 2021
@Templum
Copy link
Owner

Templum commented Mar 12, 2021

As offered earlier, will implement this feature. Follow this issue for any progress.

@Templum
Copy link
Owner

Templum commented Mar 12, 2021

Created Draft PR #91, this feature will be made available to V1

@Templum
Copy link
Owner

Templum commented Mar 15, 2021

@jebos would you willing to try out the change? Implementation and local testing were concluded.
And I plan to later merge the PR, which should make it available through the following tags develop & v1.

Please also see the following section, as this is the major difference between v0 & v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design the solution enhancement New feature or request will_implement The enhancement will be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants