-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS connections to RabbitMQ #140
Comments
Hello @CSTDev, sounds legit. I will have a look into the |
@CSTDev I will proceed with implementing this FR, please make sure to follow the progress on the PR once I started. As I will probably need to rely on you for validation. |
@CSTDev did you find the time to verify it ? |
Code looks good, haven't had a chance to verify it yet will try to get to it the end of this week. |
Any chance of adding an optional password for the client key please? Looks like passing the file to DecryptPEMBlock with the password, and then into X509KeyPair should do it. Otherwise I've got it working, thanks! |
@CSTDev thanks for getting back and testing. I'm concerned about the deprecation warning and would like to not support something already marked deprecated
|
That makes sense, I somehow missed that when I read it! |
@CSTDev alright, then I believe I will merge the PR in the next days. And release a new version. Also thanks for your good catch comment over at the PR, I resolved it today along with some flood of new tests. |
After some issues with the pipeline, due to a failure in one of the GitHub actions. I finally released this feature in v1.0.3 |
Feature request (I don't think it's currently possible?)
All connections to the Rabbitmq I'm using are required to use TLS for both the connection and client authentication. Would it be possible to add some configuration to allow a certificate, key and CA certificate chain to be provided to the underlying rabbit client?
I've noticed the library being used for the connection has a DialTLS method which I think could be used.
Happy to discuss and implement.
The text was updated successfully, but these errors were encountered: