Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Support for Private Dependencies #19

Closed
Templum opened this issue Nov 20, 2022 · 3 comments · Fixed by #21
Closed

[FR] Support for Private Dependencies #19

Templum opened this issue Nov 20, 2022 · 3 comments · Fixed by #21
Assignees
@Templum
Labels
enhancement New feature or request

Comments

@Templum
Copy link
Owner

Templum commented Nov 20, 2022

Is your feature request related to a problem? Please describe.
Right now only the pulling of publicly available dependencies is supported. However, if the code uses libraries that are private and not publicly available, it fails.

Describe the solution you'd like
Enhance the action in such a way, users can provide GOPRIVATE if needed and are able to configure git so it's possible to pull the required packages.

Additional context
Article on usage of Private Modules
@Templum Templum added the enhancement New feature or request label Nov 20, 2022
@Templum Templum self-assigned this Nov 20, 2022
@Templum Templum linked a pull request Jan 4, 2023 that will close this issue
✨ Implement support for private deps via GOPRIVATE & GH PAT #21
Merged
@Templum
Copy link
Owner Author

Templum commented Jan 5, 2023

Is there someone available that would test the version of #21, with my testing setup it worked without any issues.

@Templum
Copy link
Owner Author

Templum commented Jan 5, 2023

Instructions on how to configure the action are visible in the Readme or below:

image

@Templum
Copy link
Owner Author

Templum commented Jan 9, 2023

Support for private repositories was implemented with the help of PAT's. In case users come forward with the wish to setup SSH, this can be supported as well in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Templum Templum

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Implement support for private deps via GOPRIVATE & GH PAT Templum/govulncheck-action
1 participant
@Templum