Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new services of Oasis #121

Closed
CodeBear801 opened this issue Jan 3, 2020 · 2 comments
Closed

Add new services of Oasis #121

CodeBear801 opened this issue Jan 3, 2020 · 2 comments
Assignees
Labels
Ideas Ideas for long-term discussion Prototype Proof of concept

Comments

@CodeBear801
Copy link

CodeBear801 commented Jan 3, 2020

This issue is sub-task of #120

Before start work on Oasis, want to confirm with Jay on following items:

  • Reference project could be osrm-ranking
  • Add new folder in integration/cmd, the main function and flags' handling will be there. Need to define listenPort and osrmBackendEndpoint. osrmBackendEndpoint could be on the same machine for initial version?
  • Now integration/pkg/api mainly deal with request/response related with OSRM. If I want to add request/response for oasis, should I add folder of integration/pkg/api/oasis and put Request and Response's code there?
  • The main logic should should be in integration/oasis, which will communicate with OSRM->table service(need add) and calculate best charge station
    • routeByOSRM/tableByOSRM could be put into integration/pkg/api/service for later?
  • Oasis service might need communicate with search service, if so, will also put related code in integration/pkg/api/search
  • All code in integration will be packaged into final docker and generate excitable
  • For services inside Telenav, like Ranking, Oasis, We'd better also build a wiki page like this one: https://github.com/Telenav/osrm-backend/blob/master-telenav/docs/http.md
@wangyoucao577
Copy link

  • yes
  • yes
  • yes
  • yes.
    • For routeByOSRM/tableByOSRM, I think put them into integration/pkg/api/osrm may not good enough. They're only request by http, but may have different http parameters and error handling, e.g. timeout, GET/POST, target server, etc. Maybe put them into another package integration/service/osrm/... will be better.
  • I'll suggest to put API definition in integration/pkg/api/search if necessary. For something like PlaceSearch, put them into integration/service/search/....
  • yes. All golang binaries will be packaged into docker automatically, don't need to do anything else.
  • Agree. osrm-ranking don't need it since osrm-ranking use OSRM APIs directly. It's good to have it for the new oasis.

@CodeBear801
Copy link
Author

Thanks for your comments. Very helpful.

@CodeBear801 CodeBear801 self-assigned this Jan 28, 2020
@CodeBear801 CodeBear801 added Ideas Ideas for long-term discussion Prototype Proof of concept labels Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ideas Ideas for long-term discussion Prototype Proof of concept
Projects
None yet
Development

No branches or pull requests

2 participants