-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply image template first alpha(s) #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
suggested changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes that should probably land in the template.
joao-p-marques
added a commit
to Tecnativa/image-template
that referenced
this pull request
Jan 21, 2021
Now that this is working, do you see any other changes that might be needed in the template before releasing? |
yajo
approved these changes
Jan 22, 2021
joao-p-marques
force-pushed
the
migrate-to-template
branch
from
January 22, 2021 11:52
c94246e
to
9f6be1e
Compare
TT27819
joao-p-marques
force-pushed
the
migrate-to-template
branch
from
January 26, 2021 09:50
9f6be1e
to
49c962b
Compare
yajo
pushed a commit
that referenced
this pull request
Feb 9, 2021
Since #40, the correct labels are applied at build. These lines were 🗑 now. @Tecnativa TT27819
Merged
yajo
pushed a commit
that referenced
this pull request
Feb 9, 2021
Since #40, the correct labels are applied at build. These lines were 🗑 now. @Tecnativa TT27819
joao-p-marques
added a commit
that referenced
this pull request
Jul 5, 2021
yajo
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies https://github.com/Tecnativa/image-template
Also closes #33
@Tecnativa
TT27819
ping @yajo