Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply image template first alpha(s) #40

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

joao-p-marques
Copy link
Contributor

@joao-p-marques joao-p-marques commented Jan 21, 2021

Copy link
Contributor

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes that should probably land in the template.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
joao-p-marques added a commit to Tecnativa/image-template that referenced this pull request Jan 21, 2021
@joao-p-marques joao-p-marques requested a review from yajo January 21, 2021 15:23
@joao-p-marques joao-p-marques marked this pull request as ready for review January 21, 2021 15:23
@joao-p-marques
Copy link
Contributor Author

Now that this is working, do you see any other changes that might be needed in the template before releasing?

@joao-p-marques joao-p-marques merged commit f1de9a0 into master Jan 26, 2021
@joao-p-marques joao-p-marques deleted the migrate-to-template branch January 26, 2021 09:52
yajo pushed a commit that referenced this pull request Feb 9, 2021
Since #40, the correct labels are applied at build. These lines were 🗑 now.

@Tecnativa TT27819
@yajo yajo mentioned this pull request Feb 9, 2021
yajo pushed a commit that referenced this pull request Feb 9, 2021
Since #40, the correct labels are applied at build. These lines were 🗑 now.

@Tecnativa TT27819
joao-p-marques added a commit that referenced this pull request Jul 5, 2021
yajo pushed a commit that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versioned tags to dockerimage
2 participants