Add tests and CI #34

joao-p-marques · 2020-11-09T16:38:49Z

Takes from #14 and start apllying suggestions and improvements.

So far:

Migrate tests to pytest
Add Github Actions to run tests
Install python3 in the dockerfile.
Remove POST rule
Make sure the same image that is tested is pushed.
Publish image in ghcr.io

TT26468

From #14

yajo

Looks good! Thank you.

Lots of suggestions:

.github/workflows/test.yaml

tests/run_tests.sh

tests/test_service.py

joao-p-marques · 2020-11-25T11:31:01Z

Changes made @yajo, apart from the comment above.
I was trying to enable auto push to ghcr.io, but we need to add specific tokens, similar to Tecnativa/doodba#347

As a reference, see https://docs.github.com/en/free-pro-team@latest/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images#updating-your-github-actions-workflow (GITHUB_TOKEN is not supported, unfortunately)

.github/workflows/test.yaml

.copier-answers.autopretty.yml

.github/workflows/test.yaml

pyproject.toml

tests/test_service.py

TT26468

joao-p-marques · 2020-12-01T15:49:53Z

I've made come changes @yajo. Still WIP so pls tell me if this goes in the direction you meant.

yajo · 2020-12-02T09:51:35Z

Not exactly. Let me write that code for you.

yajo · 2020-12-02T10:51:49Z

I pushed the initial structure. It is probably failing, but I hope you can continue your WIP on top of it. I also added a very important point to your checklist in first comment: Make sure the same image that is tested is pushed.

joao-p-marques · 2020-12-02T14:28:28Z

Thank you for the suggestions @yajo
Changes made for the tests.

yajo · 2020-12-03T08:48:04Z

Is this ready to review?

joao-p-marques · 2020-12-03T08:50:13Z

I am still working on adding the auto config generator script as an entrypoint and making sure the same image that is tested is pushed.

I was thinking on marking it as ready when that is done 😃

Tests are ready for review, however.

Dockerfile

tests/test_service.py

joao-p-marques · 2020-12-03T15:13:15Z

Ended up removing:

Add the proposed script as an entrypoint.
Document usage in README.
as it didn't seem to make sense for the project after all.

joao-p-marques · 2020-12-03T15:24:52Z

We seem to be hitting docker/buildx#59. I applied docker/buildx#59 (comment) to build the image only in the runner's platform for testing purposes and then build the rest when it is time to push. This is a limitation of docker buildx when exporting to local docker, which we need to test the image.

It is not the best but we would only test one version of the image anyway (the one corresponding to the runner's platform), right? 🤷‍♂️

yajo · 2020-12-04T08:44:00Z

.github/workflows/test.yaml

+on:
+  pull_request:
+  push:
+    branches:
+      - master
+  workflow_dispatch:
+    inputs:
+      pytest_addopts:
+        description:
+          Extra options for pytest; use -vv for full details; see
+          https://docs.pytest.org/en/latest/example/simple.html#how-to-change-command-line-options-defaults
+        required: false


Do you think this is the time to implement #33 (comment)?

I'm developing for TT25794 a new python lib that will help know that you're currently in the latest tag. I'll notify you when it's done.

Yes, good suggestion. I agree that it makes sense now. I'll wait for your call then.

.github/workflows/test.yaml

tests/conftest.py

Builds the image (in single arch) before testing Loads the image into local docker (See https://github.com/docker/build-push-action#export-image-to-docker) Rebuilds and pushes the final image in multi-arch at the end.

This reverts commit dc0b60e and allows using `--prebuild` CLI flag for pytest when doing local tests.

yajo

This looks very good.

I think it's better to not block it due to #34 (comment) because that'll take a bit of time still.

joao-p-marques added 3 commits November 9, 2020 15:54

Add first version of tests

0a0b6f8

From #14

Expand tests

05ba0be

Add GH CI

0dec9ac

joao-p-marques requested a review from yajo November 9, 2020 16:38

yajo suggested changes Nov 10, 2020

View reviewed changes

joao-p-marques added 8 commits November 25, 2020 07:46

Apply suggestions

ffdd442

Apply autopretty template + fix prettier

c2fc1ff

Fix isort

7bd86a5

Apply autoprettier

0206be6

Fix VSCode settings

b21d6d8

Make tests run in parallel

0b7c5d9

Build docker image before testing

8d09134

Update workspace settings

38f530a

joao-p-marques force-pushed the add-tests branch from eac6dca to 92c8a8a Compare November 25, 2020 11:14

joao-p-marques force-pushed the add-tests branch 4 times, most recently from b49f3ef to 4779acb Compare November 25, 2020 12:40

Try multi-platform builds and push to ghcr.io

d2dad86

joao-p-marques force-pushed the add-tests branch from 4779acb to d2dad86 Compare November 25, 2020 13:36

yajo reviewed Nov 26, 2020

View reviewed changes

joao-p-marques added 3 commits November 26, 2020 09:39

Push to docker hub as well from ci

856cb49

Upgrade autopretty

a7d91ef

Update pyproject configurations

f3366b5

yajo mentioned this pull request Nov 27, 2020

Automatically update haproxy image #32

Open

joao-p-marques mentioned this pull request Nov 27, 2020

Add versioned tags to dockerimage #33

Closed

Improve test configuration and execution

0c41d3a

TT26468

Jairo Llopis and others added 2 commits December 2, 2020 14:26

Provide initial conftest

91c0652

Improve tests

3cf4ee6

joao-p-marques force-pushed the add-tests branch from 9109d34 to 3cf4ee6 Compare December 2, 2020 14:27

Add python3 in image

1f4bd85

yajo reviewed Dec 3, 2020

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

Dockerfile Outdated Show resolved Hide resolved

tests/test_service.py Show resolved Hide resolved

Remove POST rule from proxy

764ece5

joao-p-marques force-pushed the add-tests branch from 898582c to f66b9c5 Compare December 3, 2020 15:19

joao-p-marques marked this pull request as ready for review December 3, 2020 15:24

joao-p-marques force-pushed the add-tests branch from f66b9c5 to d2416e8 Compare December 3, 2020 15:28

yajo reviewed Dec 4, 2020

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

joao-p-marques added 3 commits December 4, 2020 09:06

Build image before testing and push at the end

d9d5b44

Builds the image (in single arch) before testing Loads the image into local docker (See https://github.com/docker/build-push-action#export-image-to-docker) Rebuilds and pushes the final image in multi-arch at the end.

Fix python path

47f8f46

Remove build fixture from tests to see if image is built in CI

dc0b60e

joao-p-marques force-pushed the add-tests branch from 08c7cff to dc0b60e Compare December 4, 2020 09:07

joao-p-marques and others added 2 commits December 4, 2020 10:01

Organize docker tests definition and document

b46fc70

Restore fixture allowing usage for local testing

15071f7

This reverts commit dc0b60e and allows using `--prebuild` CLI flag for pytest when doing local tests.

yajo approved these changes Dec 10, 2020

View reviewed changes

yajo merged commit e84babd into master Dec 10, 2020

yajo deleted the add-tests branch December 10, 2020 08:52

joao-p-marques mentioned this pull request Jan 28, 2021

Add tests and a dynamic config section generator #14

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests and CI #34

Add tests and CI #34

joao-p-marques commented Nov 9, 2020 •

edited

Loading

yajo left a comment

joao-p-marques commented Nov 25, 2020

joao-p-marques commented Dec 1, 2020

yajo commented Dec 2, 2020

yajo commented Dec 2, 2020

joao-p-marques commented Dec 2, 2020

yajo commented Dec 3, 2020

joao-p-marques commented Dec 3, 2020

joao-p-marques commented Dec 3, 2020

joao-p-marques commented Dec 3, 2020

yajo Dec 4, 2020

joao-p-marques Dec 4, 2020

yajo left a comment

Add tests and CI #34

Add tests and CI #34

Conversation

joao-p-marques commented Nov 9, 2020 • edited Loading

yajo left a comment

Choose a reason for hiding this comment

joao-p-marques commented Nov 25, 2020

joao-p-marques commented Dec 1, 2020

yajo commented Dec 2, 2020

yajo commented Dec 2, 2020

joao-p-marques commented Dec 2, 2020

yajo commented Dec 3, 2020

joao-p-marques commented Dec 3, 2020

joao-p-marques commented Dec 3, 2020

joao-p-marques commented Dec 3, 2020

yajo Dec 4, 2020

Choose a reason for hiding this comment

joao-p-marques Dec 4, 2020

Choose a reason for hiding this comment

yajo left a comment

Choose a reason for hiding this comment

joao-p-marques commented Nov 9, 2020 •

edited

Loading