Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry-core migration breaks for projects not using major.minor.patch version references #76

Closed
d-ryan-ashcraft opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@d-ryan-ashcraft
Copy link
Contributor

The recently added #66 automatically upgrade poetry-core versions to the minimum used by Habushu. Unfortunately, it also breaks when the project's existing pyproject.toml file does not use a major.minor.patch versioning pattern.

For instance, the following pyproject.toml snippet will break the process:

[build-system]
requires = ["poetry-core>=1.6"]
build-backend = "poetry.core.masonry.api"

We should resolve this so any valid poetry-core version will be seamlessly upgraded.

@d-ryan-ashcraft d-ryan-ashcraft added the bug Something isn't working label Jan 3, 2024
@d-ryan-ashcraft
Copy link
Contributor Author

WORKAROUND
In the meantime, you can work around this defect by update the version to be in the form of major.minor.patch. For instance, migrate requires = ["poetry-core>=1.6"] to instead be requires = ["poetry-core>=1.6.0"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant