[POST] /auth/signup 회원가입 구현 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngkwon02
reviewed
Jan 10, 2022
Comment on lines
+1
to
+18
| const functions = require('firebase-functions'); | ||
| const admin = require('firebase-admin'); | ||
| const util = require('../../../lib/util'); | ||
| const statusCode = require('../../../constants/statusCode'); | ||
| const responseMessage = require('../../../constants/responseMessage'); | ||
| const db = require('../../../db/db'); | ||
| const { userDB } = require('../../../db'); | ||
| const jwtHandlers = require('../../../lib/jwtHandlers'); | ||
|
|
||
| /** | ||
| * @회원가입 | ||
| * @route POST /auth/signup | ||
| * @body socialId:string, nickname:string, profileImg:file | ||
| * @error | ||
| * 1. socialId/nickname이 전달되지 않음 | ||
| * 2. 이미 존재하는 socialId | ||
| * 3. 닉네임 10자 초과 | ||
| */ |
There was a problem hiding this comment.
첨에 고민하다가 Annotation을 require 이전에 작성했었는데, 요렇게 하셨군요~~
설희쌤 따라 다음 api부터는 요렇게 갑니다~~~ㅋㅋㅋㅋㅋㅋㅎ
youngkwon02
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Default Checklist
check branch
set Labels
set Reviewers
📕 Task
💡TODO