Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GET] /room/:roomId 특정 습관방 조회 #31

Merged
merged 7 commits into from
Jan 13, 2022
Merged

[GET] /room/:roomId 특정 습관방 조회 #31

merged 7 commits into from
Jan 13, 2022

Conversation

xxeol2
Copy link
Contributor

@xxeol2 xxeol2 commented Jan 12, 2022

No description provided.

@xxeol2 xxeol2 self-assigned this Jan 12, 2022
Comment on lines 29 to 30
dayjs.extend(utc);
dayjs.extend(timezone);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 utc, timezone을 extend 안해주면 작동하지 않는 dayjs 연산이 있을까요??!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timezone때문에 추가했다가, 삭제하는걸 깜빡했네요! 수정할게요 감사해요:)

otherRecords
}

res.status(statusCode.OK).send(util.success(statusCode.OK, responseMessage.GET_ROOM_DETAIL_SUCCESS, data));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"GET_ROOM_DETAIL_SUCCESS"
이 ResponseMessage 등록 안해주셨어요~~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗! pull받으면서 삭제됐네요 추가할게요!!😀

Copy link
Member

@youngkwon02 youngkwon02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😆

@xxeol2 xxeol2 merged commit f77a263 into develop Jan 13, 2022
@xxeol2 xxeol2 deleted the feature/#13 branch January 13, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants