Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The only Piped instance which handles live streams is https://piped.privacydev.net/ , now and ever since other instances started to fail. #3407

Closed
ghost opened this issue Feb 17, 2024 · 11 comments
Labels
help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Feb 17, 2024

The only Piped instance which handles live streams is https://piped.privacydev.net/ , now and ever since other instances started to fail.
Though, concerning this particular instance, better to choose its very api instance to another than its own : adminforge.de is excellent.
Why, I have no idea. Impossible to find an explanation. I even emailed this oddity to the owner of privacydev.net who never answered.
I've tried them all, https://piped.privacydev.net/ is the ONLY instance that does it.
Not to mention that many instances displayed on the Piped instances page have been out of service for some time : why aren't they removed, at least by their owners ? Looks like they've discovered Piped, decided to join, and when their servers no longer handle Piped, they just don't care and leave their Piped instance listed : a total lack of respect.

By the way, this bug is not fixed so why has this thread been moved to closed issues? This is and remains an issue. In whatever Piped instance, search i.e.for 'Sky News' and it will include in its results 'Sky News Live' which does not resolve... except, again, on https://piped.privacydev.net/

Originally posted by @Cade66 in #3090 (comment)

@ghost

This comment was marked as abuse.

@Bnyro
Copy link
Member

Bnyro commented Mar 1, 2024

Warning due to tagging team members - that's not permitted, see https://github.com/TeamPiped/Piped/blob/master/CODE_OF_CONDUCT.md.

If you want to be toxic, go to Telegram.

@Bnyro Bnyro added help wanted Extra attention is needed and removed cant-reproduce labels Mar 1, 2024
@Bnyro
Copy link
Member

Bnyro commented Mar 1, 2024

In this case, this was a missclick - no reason to become toxic right away.

@ghost

This comment was marked as spam.

@0x24D
Copy link
Contributor

0x24D commented Mar 2, 2024

Piped:

0dd45b68c7559936e90a282de12681ccb67e15e7 is the first bad commit
commit 0dd45b68c7559936e90a282de12681ccb67e15e7
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Aug 31 00:41:34 2023 +0000

    fix(deps): update dependency shaka-player to v4.4.0

 package.json   | 2 +-
 pnpm-lock.yaml | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

shaka-player:
shaka-project/shaka-player@v4.3.9...v4.4.0

eec25b2c6efc1cccc35509131c37bd4569d54b9e is the first bad commit
commit eec25b2c6efc1cccc35509131c37bd4569d54b9e
Author: Álvaro Velad Galván <[email protected]>
Date:   Tue Aug 29 23:53:57 2023 +0200

    feat: Add TS transmuxer (#5386)
    
    - Allow to have multiple transmuxers, but choose only the one that is
    valid depending on whether it supports the codecs or not
    - Supported codecs: AAC, AC-3, EC-3, H.264, MPEG/MP3
    - It is prepared to allow more codecs in the future (HEVC/H.265) (no
    muxed)

 README.md                                          |  10 +-
 build/types/transmuxer                             |   3 +
 externs/shaka/codecs.js                            |  32 +
 karma.conf.js                                      |   3 +
 lib/media/media_source_engine.js                   |   6 +-
 lib/mss/mss_parser.js                              |   2 +
 lib/transmuxer/aac_transmuxer.js                   |   2 +
 lib/transmuxer/ac3_transmuxer.js                   |   2 +
 lib/transmuxer/ec3_transmuxer.js                   |   2 +
 lib/transmuxer/h264.js                             | 324 ++++++++++
 lib/transmuxer/mp3_transmuxer.js                   |   2 +
 lib/transmuxer/mpeg_ts_transmuxer.js               | 182 ++++++ 
 lib/transmuxer/transmuxer_engine.js                |  63 +-
 lib/transmuxer/ts_transmuxer.js                    | 689 +++++++++++++++++++++
 lib/util/exp_golomb.js                             |  14 +
 lib/util/mime_utils.js                             |   1 +
 lib/util/mp4_generator.js                          | 127 ++--
 lib/util/ts_parser.js                              | 213 +++++--
 shaka-player.uncompiled.js                         |   3 +
 test/media/drm_engine_unit.js                      |  12 +
 .../ChID_voices_6ch_640kbps_dd_sub_0000.ts         | Bin 0 -> 516248 bytes
 .../ChID_voices_6ch_640kbps_dd_sub_0001.ts         | Bin 0 -> 513804 bytes
 .../ChID_voices_6ch_640kbps_dd_sub_0002.ts         | Bin 0 -> 516248 bytes
 .../ChID_voices_6ch_640kbps_dd_sub_0003.ts         | Bin 0 -> 513804 bytes
 .../ChID_voices_6ch_640kbps_dd_sub_0004.ts         | Bin 0 -> 516248 bytes
 .../ChID_voices_6ch_640kbps_dd_sub_0005.ts         | Bin 0 -> 513804 bytes
 test/test/assets/hls-ts-ac3/prog_index.m3u8        |  19 +
 .../ChID_voices_6ch_256kbps_ddp_sub_0000.ts        | Bin 0 -> 212440 bytes
 .../ChID_voices_6ch_256kbps_ddp_sub_0001.ts        | Bin 0 -> 211312 bytes
 .../ChID_voices_6ch_256kbps_ddp_sub_0002.ts        | Bin 0 -> 212440 bytes
 .../ChID_voices_6ch_256kbps_ddp_sub_0003.ts        | Bin 0 -> 211312 bytes
 .../ChID_voices_6ch_256kbps_ddp_sub_0004.ts        | Bin 0 -> 212440 bytes
 .../ChID_voices_6ch_256kbps_ddp_sub_0005.ts        | Bin 0 -> 211312 bytes
 test/test/assets/hls-ts-ec3/prog_index.m3u8        |  19 +
 test/test/assets/hls-ts-mp3/manifest.m3u8          |  13 +
 test/test/assets/hls-ts-mp3/media_w239891843_0.ts  | Bin 0 -> 96256 bytes
 test/test/assets/hls-ts-mp3/media_w239891843_1.ts  | Bin 0 -> 96256 bytes
 test/test/assets/hls-ts-mp3/media_w239891843_2.ts  | Bin 0 -> 96256 bytes
 test/test/assets/hls-ts-mp3/media_w239891843_3.ts  | Bin 0 -> 96256 bytes
 test/transmuxer/transmuxer_engine_integration.js   |  13 -
 test/transmuxer/transmuxer_integration.js          |  96 +++
 41 files changed, 1693 insertions(+), 159 deletions(-)
 create mode 100644 externs/shaka/codecs.js
 create mode 100644 lib/transmuxer/h264.js
 create mode 100644 lib/transmuxer/mpeg_ts_transmuxer.js
 create mode 100644 lib/transmuxer/ts_transmuxer.js
 create mode 100644 test/test/assets/hls-ts-ac3/ChID_voices_6ch_640kbps_dd_sub_0000.ts
 create mode 100644 test/test/assets/hls-ts-ac3/ChID_voices_6ch_640kbps_dd_sub_0001.ts
 create mode 100644 test/test/assets/hls-ts-ac3/ChID_voices_6ch_640kbps_dd_sub_0002.ts
 create mode 100644 test/test/assets/hls-ts-ac3/ChID_voices_6ch_640kbps_dd_sub_0003.ts
 create mode 100644 test/test/assets/hls-ts-ac3/ChID_voices_6ch_640kbps_dd_sub_0004.ts
 create mode 100644 test/test/assets/hls-ts-ac3/ChID_voices_6ch_640kbps_dd_sub_0005.ts
 create mode 100644 test/test/assets/hls-ts-ac3/prog_index.m3u8
 create mode 100644 test/test/assets/hls-ts-ec3/ChID_voices_6ch_256kbps_ddp_sub_0000.ts
 create mode 100644 test/test/assets/hls-ts-ec3/ChID_voices_6ch_256kbps_ddp_sub_0001.ts
 create mode 100644 test/test/assets/hls-ts-ec3/ChID_voices_6ch_256kbps_ddp_sub_0002.ts
 create mode 100644 test/test/assets/hls-ts-ec3/ChID_voices_6ch_256kbps_ddp_sub_0003.ts
 create mode 100644 test/test/assets/hls-ts-ec3/ChID_voices_6ch_256kbps_ddp_sub_0004.ts
 create mode 100644 test/test/assets/hls-ts-ec3/ChID_voices_6ch_256kbps_ddp_sub_0005.ts
 create mode 100644 test/test/assets/hls-ts-ec3/prog_index.m3u8
 create mode 100644 test/test/assets/hls-ts-mp3/manifest.m3u8
 create mode 100644 test/test/assets/hls-ts-mp3/media_w239891843_0.ts
 create mode 100644 test/test/assets/hls-ts-mp3/media_w239891843_1.ts
 create mode 100644 test/test/assets/hls-ts-mp3/media_w239891843_2.ts
 create mode 100644 test/test/assets/hls-ts-mp3/media_w239891843_3.ts

@Bnyro
Copy link
Member

Bnyro commented Mar 5, 2024

Help wanted doesn't really correspond to what I've reported, together with others whom as myself consider using Piped with live streams. Information wanted would be more appropriate, should the label exist. Better : Information begged for, if prudery should stand as deeply non-toxic.

I think it was late October 2023 that a new development of Piped led to YouTube live streams no longer being handled. All updated instances led to the same issue and it seems that https://piped.privacydev.net/ kept code others did not which would explain why it is -- in my experience -- the only instance that allows -- at this time -- to have live streams handled correctly. The instance's proxy is not concerned, it's the very instance which makes the difference.

This has been reported and what is wished is less an immediate solution than a word of explanation. Yet, not one word for over four months. This explains the tone of exasperation which didn't mean to be toxic even if perceived as such.

Thanks for switching the label to Help wanted.

Thanks for your appreciation of open source work.

@Bnyro
Copy link
Member

Bnyro commented Mar 5, 2024

Help wanted means external contributions to fix this are welcome.

@ghost

This comment was marked as spam.

@Bnyro

This comment was marked as outdated.

@0x24D
Copy link
Contributor

0x24D commented Mar 5, 2024

As per shaka-project/shaka-player#6322 (comment), downgrading to shaka-player v4.3.15 (and reintroducing mux.js) will resolve the livestream issue until it is resolved in the current version.

However the shaka-player downgrade causes the "Concurrent Stream Prefetch Limit" preference to stop taking effect due to the fact that the underlying shaka-player config streaming.segmentPrefetchLimit didn't exist until v4.4.x.

@Bnyro
Copy link
Member

Bnyro commented Mar 14, 2024

Duplicate of #2898, let's continue there.

@Bnyro Bnyro marked this as a duplicate of #2898 Mar 14, 2024
@Bnyro Bnyro closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants